Use CompletionItemLabelDetails from LSP4J 0.20.0 for detailed completion list#116
Open
trustytrojan wants to merge 2 commits into
Open
Conversation
… completion menu for property/method access
…r `ClassNode` & `Variable` completions
CompletionItemLabelDetails from LSP4J 0.20.0 for detailed method/property completion menuCompletionItemLabelDetails from LSP4J 0.20.0 for detailed completion list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.eclipse.lsp4j.jsonrpcas an explicit dependency as to letorg.eclipse.lsp4jitself require the version oforg.eclipse.lsp4j.jsonrpcit needsCompletionItemLabelDetailsobject to setdetailto the argument list of methods anddescriptionto the return type of methods and the types of properties/fields. This allows for a nicer looking completion menu showing much more information about methods/properties/fields at a glance in VS Code. (This also brings the completion menu to parity with Eclipse JDT LS.)CompletionItemLabelDetailsobjectsCompletionItemLabelDetailsfor class/type completions to show the package of each class as thedescriptionfield. The package name shows up in the same place that method/field/variable types do.Visual demonstration
With the following class available in scope, below are screenshots of the completion menu after typing
new TestClass().:Before
After